Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change antialias default from None to True #7949

Merged
merged 7 commits into from Sep 25, 2023

Conversation

NicolasHug
Copy link
Member

@NicolasHug NicolasHug commented Sep 8, 2023

(Actually: from "warn" to True).

After a deprecation cycle of 2 releases, we can now finally change the default for 0.17.
This is the last step of #7093

cc @vfdev-5

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 8, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7949

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit 3325b71 with merge base 68fbd3c (image):

NEW FAILURE - The following job has failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@NicolasHug NicolasHug marked this pull request as ready for review September 25, 2023 11:13
Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@NicolasHug NicolasHug merged commit ace9221 into pytorch:main Sep 25, 2023
61 of 63 checks passed
@github-actions
Copy link

Hey @NicolasHug!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

facebook-github-bot pushed a commit that referenced this pull request Sep 26, 2023
Reviewed By: matteobettini

Differential Revision: D49600767

fbshipit-source-id: 0098683c445c19179dc6489c2c304dad226bfad4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants