[FBcode->GH] Remove deprecated functional modules #7953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 31, 2023
Summary: This is a fake-import of #7953 Reviewed By: vmoens Differential Revision: D49638352 fbshipit-source-id: 2c9aee198138f95c95462510f2978cd0aed2afa6
NicolasHug
changed the title
NicolasHug
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
Thank you @pmeier.
I already imported this PR internally on fbcode and was able to land it after fixing a bunch of internal code-bases. It's been in for ~1week now and things are OK, so it's safe to merge.
Note for self: since I already imported it, I'll prefix it with [FBcode->GH] so that it doesn't get picked up by the sync.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sister PR to #7949. Acts on #7269, which was included with 0.15 and thus the deprecation is finished with the upcoming 0.17 release.
cc @vfdev-5