Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add torchscript test for io image stuff #8313

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Conversation

NicolasHug
Copy link
Member

All of our io stuff supports torchscript but somehow, we never properly tested for that. This PR adds tests for all the relevant APIs form image.py. I'm ignoring the video stuff.

Copy link

pytorch-bot bot commented Mar 13, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8313

Note: Links to docs will display an error until the docs builds have been completed.

❌ 16 New Failures, 18 Unrelated Failures

As of commit 460c222 with merge base eb815ae (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@NicolasHug NicolasHug merged commit c7bcfad into pytorch:main Mar 13, 2024
11 of 45 checks passed
@NicolasHug NicolasHug deleted the pathlibio branch March 13, 2024 16:23
Copy link

Hey @NicolasHug!

You merged this PR, but no labels were added.
The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

facebook-github-bot pushed a commit that referenced this pull request Mar 20, 2024
Reviewed By: vmoens

Differential Revision: D55062802

fbshipit-source-id: bd12211c671c73dffedbff947959609a55924a79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: done
Development

Successfully merging this pull request may close these issues.

3 participants