Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lower native_dropout #5643

Merged
merged 8 commits into from
Sep 26, 2023
Merged

lower native_dropout #5643

merged 8 commits into from
Sep 26, 2023

Conversation

zpcore
Copy link
Collaborator

@zpcore zpcore commented Sep 25, 2023

Fix #5588.

Added the manual lowering for native_dropout op. We need to add the test to verify whether the logic is correct or not.

@zpcore zpcore added the codegen label Sep 25, 2023
@lsy323 lsy323 changed the title Piz/codegen 1 lower native_dropout Sep 25, 2023
lsy323
lsy323 reviewed Sep 25, 2023
View reviewed changes
torch_xla/csrc/ops/native_dropout.cpp Outdated Show resolved Hide resolved
torch_xla/csrc/ops/native_dropout.cpp Outdated Show resolved Hide resolved
lsy323
lsy323 reviewed Sep 25, 2023
View reviewed changes
test/cpp/test_aten_xla_tensor_1.cpp Outdated Show resolved Hide resolved
torch_xla/csrc/tensor_methods.cpp Outdated Show resolved Hide resolved
lsy323
lsy323 reviewed Sep 26, 2023
View reviewed changes
torch_xla/csrc/ops/native_dropout.cpp Outdated Show resolved Hide resolved
torch_xla/csrc/xla_lower_util.cpp Outdated Show resolved Hide resolved
@lsy323
Copy link
Collaborator

lsy323 commented Sep 26, 2023

@zpcore Thanks for working on this, good work!

@zpcore zpcore merged commit 2c6e4a7 into master Sep 26, 2023
18 checks passed
@zpcore
Copy link
Collaborator Author

zpcore commented Sep 26, 2023

Thanks @JackCaoG and @lsy323 for the feedback, it's a great learning experience!

@zpcore zpcore deleted the piz/codegen-1 branch September 26, 2023 16:45
ManfeiBai pushed a commit that referenced this pull request Sep 26, 2023
@zpcore @ManfeiBai
lower native_dropout (#5643)
8d3171c 
* prototype version (compiling error)

* Add native_dropout manual lowering.

* fix to tensor IR and add a simple native_dropout test

* fix data type issue and update test case

* fix IR hash issue

* fix corner case when probability==0

* remove typo line

* add test case when probability=0
@ManfeiBai ManfeiBai mentioned this pull request Sep 26, 2023
Merged
ManfeiBai added a commit that referenced this pull request Sep 26, 2023
@ManfeiBai @JackCaoG @zpcore
lower NativeDropoutBackward (#5642) and lower native_dropout (#5643) (#…
b840137 
…5647)

* lower NativeDropoutBackward (#5642)

* lower NativeDropoutBackward

* fix lowering and add python test

* lower native_dropout (#5643)

* prototype version (compiling error)

* Add native_dropout manual lowering.

* fix to tensor IR and add a simple native_dropout test

* fix data type issue and update test case

* fix IR hash issue

* fix corner case when probability==0

* remove typo line

* add test case when probability=0

---------

Co-authored-by: JackCaoG <59073027+JackCaoG@users.noreply.github.com>
Co-authored-by: zpcore <piz@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vanbasten23 vanbasten23 vanbasten23 left review comments

@JackCaoG JackCaoG JackCaoG left review comments

@lsy323 lsy323 lsy323 approved these changes

@yeounoh yeounoh Awaiting requested review from yeounoh

Assignees
No one assigned
Labels
op lowering
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OP lowering for op native_dropout
4 participants
@zpcore @lsy323 @vanbasten23 @JackCaoG