Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration serialization and deserialization #60

Merged
merged 2 commits into from
Apr 17, 2023

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Apr 10, 2023

This is a port of the work done in dask/dask#6987

It adds a serialize and deserialize function to make it easier to send a config to a remote machine as an environment variable. I also added a convenience Config.serialize which serializes the current Config object.

CC @jhamman who might be interested in this since we've talked about serialization in the past.
Also CC @jacobtomlinson in case he has any opinions.

@djhoese djhoese added the enhancement New feature or request label Apr 10, 2023
@djhoese djhoese requested a review from jhamman April 10, 2023 16:49
@djhoese djhoese self-assigned this Apr 10, 2023
@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Merging #60 (02acff5) into main (0089d00) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
+ Coverage   98.11%   98.18%   +0.07%     
==========================================
  Files           6        6              
  Lines         689      717      +28     
==========================================
+ Hits          676      704      +28     
  Misses         13       13              
Flag Coverage Δ
unittests 98.18% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
donfig/__init__.py 100.00% <100.00%> (ø)
donfig/config_obj.py 95.27% <100.00%> (+0.21%) ⬆️
donfig/tests/test_config.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@djhoese djhoese merged commit 21ae3c6 into pytroll:main Apr 17, 2023
@djhoese djhoese deleted the feature-serialize branch April 17, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants