Make it possible to configure publisher with a dictionary of settings #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #35 +/- ##
==========================================
+ Coverage 78.57% 79.50% +0.93%
==========================================
Files 15 15
Lines 1792 1888 +96
==========================================
+ Hits 1408 1501 +93
- Misses 384 387 +3
Continue to review full report at Codecov.
|
…uu/posttroll into feature-publisher-dict_config
mraspaud
approved these changes
Nov 16, 2021
There was a problem hiding this comment.
LGTM. I'm not really happy with the tests checking how Publisher is called, it feels like we are testing the implementation rather than the behaviour of the class. But I think that making Publisher testable needs much more work than is reasonable within the scope of this PR, so I'm merging this.
This was referenced Dec 22, 2021
gerritholl
added a commit
to gerritholl/pytroll-cspp-runner
that referenced
this pull request
Dec 22, 2021
Add an option to use publisher configuration from a file. Needs merger of posttroll #35 pytroll/posttroll#35
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make publisher selection easier for the user, this PR adds an utility function that selects the publisher based on the given settings.