Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use publisher config. #14

Merged
merged 7 commits into from
May 24, 2022
Merged

Conversation

gerritholl
Copy link
Collaborator

@gerritholl gerritholl commented Dec 22, 2021

Add an option to use a publisher configuration file.

Needs posttroll 1.7.

@gerritholl gerritholl marked this pull request as ready for review December 23, 2021 09:38
@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #14 (2cfa513) into main (da40178) will increase coverage by 0.31%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
+ Coverage   78.13%   78.45%   +0.31%     
==========================================
  Files          12       12              
  Lines         956      970      +14     
==========================================
+ Hits          747      761      +14     
  Misses        209      209              
Flag Coverage Δ
unittests 78.45% <100.00%> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cspp_runner/runner.py 85.36% <100.00%> (+0.20%) ⬆️
cspp_runner/tests/test_runner.py 98.93% <100.00%> (+0.02%) ⬆️
cspp_runner/tests/test_viirs_dr_runner.py 100.00% <100.00%> (ø)
cspp_runner/viirs_dr_runner.py 96.66% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da40178...2cfa513. Read the comment docs.

@gerritholl gerritholl mentioned this pull request Apr 29, 2022
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thank you for this feature. The way we usually to things in pytroll runners/collectors is to have one config file for the whole process, but this seems like a more flexible way to provide configuration to each component, eg the publisher config can be used across multiple process.

@mraspaud mraspaud merged commit c87250d into pytroll:main May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make publisher configurable
2 participants