Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attribute Finetuning #14

Merged
merged 10 commits into from Jul 14, 2020
Merged

Attribute Finetuning #14

merged 10 commits into from Jul 14, 2020

Conversation

sfinkens
Copy link
Member

@sfinkens sfinkens commented Jul 8, 2020 •
edited

Closes #11

This PR will change the config file format (metadata -> global_attrs, new section gac_header_attrs).

Answers

Possible Improvements:

  1. Yes they could be expressed as a bit map, but in my experience decoding bitmaps is challenging for some users. But I added a comment pointing to the flag meanings.
  2. Removed fill value
  3. Fixed

Trivial attribute tweaks:

  1. Added standard_name and axis attributes to acq_time.
  2. Lon/lat are 2D. Instead added 1D y and x coordinates for pixel/line number, including axis attributes.
  3. Moved contact to creator_email. TODO: Is our interpretation of time_coverage_start/end incorrect?
  4. Ignored 馃檪
  5. Fixed, see Preserve chunks in CF Writer聽satpy#1254
  6. Added reference to POD/KLM user guides

@sfinkens sfinkens self-assigned this Jul 8, 2020
@sfinkens sfinkens added enhancement New feature or request bug Something isn't working labels Jul 8, 2020
@sfinkens sfinkens merged commit 916a3b9 into pytroll:master Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sfinkens sfinkens

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Attribute Finetuning
1 participant
@sfinkens