Preserve chunks in CF Writer #1254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfinkens
added
component:writers
enhancement
Codecov Report
@@ Coverage Diff @@
## master #1254 +/- ##
=======================================
Coverage 90.51% 90.52%
=======================================
Files 228 228
Lines 33334 33377 +43
=======================================
+ Hits 30173 30214 +41
- Misses 3161 3163 +2
Continue to review full report at Codecov.
|
|
I just noticed that also coordinate variables like latitude or longitude can be chunked. |
sfinkens
force-pushed
the
cf-writer-chunks
branch
from
c27beb2
to
1951de4
Compare
mraspaud
reviewed
Sep 8, 2020
djhoese
reviewed
Sep 8, 2020
| @@ -616,6 +632,7 @@ def save_datasets(self, datasets, filename=None, groups=None, header_attrs=None, | |||
| root.attrs['Conventions'] = CF_VERSION | |||
|
|
|||
| # Remove satpy-specific kwargs | |||
| to_netcdf_kwargs = copy.deepcopy(to_netcdf_kwargs) # may contain dictionaries (encoding) | |||
| satpy_kwargs = ['overlay', 'decorate', 'config_files'] | |||
There was a problem hiding this comment.
I know you didn't do this, but it is too bad we have to do this. I'm sure it will come to bite us in the future.
|
@sfinkens what is the status on this? Do you think you can have it ready by friday? |
|
@mraspaud Yes, I think that's possible! |
Replace DataArray.drop with .drop_vars
|
@mraspaud Done! |
mraspaud
approved these changes
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the encoding applied by the CF writer so that generated netCDF files are chunked like the original dask arrays. Chunks specified by the user via
encoding={'foo': {'chunksizes': (1024, 1024)}}take precedence.I tested this with a LEO scene (
avhrr_gaclac_l1b), a single geostationary scene (ahi_hsd) and a timeseries ofahi_hsdscenes (via Multiscene). The latter has some problems with time bounds (see #1242), but the chunking works fine.I also tested both the
netCDF4and theh5netcdfbackend.Edit: I also removed the new
_satpy*attributes before writing datasets to netcdf`.flake8 satpy