Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update get_next_passes docstring #157

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Conversation

simonrp84
Copy link
Member

@simonrp84 simonrp84 commented Jul 3, 2024

Currently, the documentation for get_next_passes is unclear. It does not specify what units should be used for the altitude. This PR updates the docstring to make clear that altitude should be in km.

  • Fully documented

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.99%. Comparing base (3247b15) to head (8542447).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #157   +/-   ##
=======================================
  Coverage   87.99%   87.99%           
=======================================
  Files          14       14           
  Lines        2241     2241           
=======================================
  Hits         1972     1972           
  Misses        269      269           
Flag Coverage Δ
unittests 87.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pnuu pnuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@coveralls
Copy link

Coverage Status

coverage: 87.933%. remained the same
when pulling 8542447 on simonrp84:fix_orb_docstr
into 5b4f336 on pytroll:main.

@pnuu pnuu merged commit 652b30d into pytroll:main Jul 3, 2024
17 checks passed
@simonrp84 simonrp84 deleted the fix_orb_docstr branch July 4, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants