-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with PyProj v2.6.0 #258
Conversation
OK, the problem on OSX seems to be not related to this PR. Can someone please re-trigger a new test on Travis? [1] https://travis-ci.org/github/avalentino/pyresample/builds/664359903 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. You're right that the tests are not your fault and are an upstream libtiff/libwebp issue. Otherwise I think this all works for me. I should really rewrite this code to depend on pyproj's cython exports directly. They didn't exist when I first wrote this.
@djhoese do we have an issue for this ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mraspaud , in case you are interested in, there is a debian bug for this [1]. [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=954219 |
@avalentino thanks! I was thinking about having an issue regarding the usage of cython exports directly, sorry for being unclear. |
No I don't think there is. It was one of those things that since it isn't broken I wasn't going to worry about fixing it since it would be a lot of research and time potentially. |
Ok, merging this. @avalentino thank you for the quick PR! |
So I know this is merged but I looked up what options there are from loading from the cython module directly. It looks like this could be replaced with |
git diff origin/master **/*py | flake8 --diff