-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests on i386 #540
Merged
djhoese
merged 1 commit into
pytroll:main
from
avalentino:bugfix/floating-point-comparison
Sep 9, 2023
Merged
Fix tests on i386 #540
djhoese
merged 1 commit into
pytroll:main
from
avalentino:bugfix/floating-point-comparison
Sep 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #540 +/- ##
=======================================
Coverage 94.25% 94.25%
=======================================
Files 82 82
Lines 13077 13077
=======================================
Hits 12326 12326
Misses 751 751
Flags with carried forward coverage won't be shown. Click here to find out more.
|
djhoese
approved these changes
Sep 9, 2023
Thanks! |
Just curious, how close were the results on i386 to the expected/compared results? |
I think something very close to the epsilon of float64
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff origin/main **/*py | flake8 --diff