Bump up python versions #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #204 +/- ##
==========================================
+ Coverage 89.27% 89.96% +0.68%
==========================================
Files 23 23
Lines 2545 2580 +35
==========================================
+ Hits 2272 2321 +49
+ Misses 273 259 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
djhoese
approved these changes
Nov 17, 2023
|
Oh no. Looks like unit tests need to be updated. |
|
We got a failed mamba in windows/3.12, anyone that knows what this is about? https://github.com/pytroll/pyspectral/actions/runs/6954968200/job/18923229713?pr=204 |
|
Oh, it's pyhdf which doesn't support python 3.12 on windows |
|
Removed pyhdf and h5netcdf from then ci env as they don't seem to be imported anywhere in pyspectral |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps up the python versions to be in line with the scientific python community.