Fix geogrid chunking to accept "auto" and to preserve dtype #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #61 +/- ##
==========================================
+ Coverage 88.07% 88.31% +0.24%
==========================================
Files 21 21
Lines 1434 1464 +30
==========================================
+ Hits 1263 1293 +30
Misses 171 171
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
djhoese
reviewed
Nov 15, 2023
|
|
||
| vchunks = range(0, shape[0], v_chunk_size) | ||
| hchunks = range(0, shape[1], h_chunk_size) | ||
| chunks = normalize_chunks(chunks, shape, dtype=self.values.dtype) |
There was a problem hiding this comment.
Is there no input dask array to take the chunk size from or to calculate the chunk size from (ex. multiply by a factor)?
There was a problem hiding this comment.
I think this is very dependent on the input data/reader. In the cases where the chunk sizes are known and provided here, normalize_chunks should not be interfering.
Eg:
In [6]: normalize_chunks(((2, 2, 2, 2, 2), (2, 2, 2, 2, 2)), (10, 10), dtype=np.float32)
Out[6]: ((2, 2, 2, 2, 2), (2, 2, 2, 2, 2))However, using it allows passing more abstract values, like 10MiB or auto.
djhoese
approved these changes
Nov 15, 2023
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the GeoGridInterpolator to preserve type and accept "auto" and other string chunk specifications.
git diff origin/main **/*py | flake8 --diff