Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gatherer does not complain when configuration file does not exist #72

Closed
gerritholl opened this issue Jan 14, 2021 · 1 comment · Fixed by #109
Closed

gatherer does not complain when configuration file does not exist #72

gerritholl opened this issue Jan 14, 2021 · 1 comment · Fixed by #109

Comments

@gerritholl
Copy link
Contributor

Summary

When the configuration file passed to gatherer does not exist (or otherwise cannot be read), there is neither a warning nor an error from gatherer.py. From the console output (or logfile output) there is no direct indication that anything is wrong — only the indirect evidence from the observation that it doesn't seem to be doing much.

MCVE

$ gatherer.py -v /does/not/exist

Expected output

I think this should fail immediately, as I don't see any way in which this error could be recoverable.

Actual output

$ gatherer.py -v /does/not/exist
Setting timezone to UTC
[INFO: 2021-01-14 15:02:24 : posttroll.publisher] publisher started on port 38155
gerritholl added a commit to gerritholl/pytroll-collectors that referenced this issue Jul 1, 2022
Confirm the configuration file was read successfully when initialising
the geographic gatherer.

Fixes pytroll#72.
@gerritholl
Copy link
Contributor Author

From the ConfigParser.read documentation:

Files that cannot be opened are silently ignored; this is designed so that you can specify an iterable of potential configuration file locations (e.g. current directory, user's home directory, systemwide directory), and all existing configuration files in the iterable will be read. A single filename may also be given.

:S

@pnuu pnuu closed this as completed in #109 Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant