Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix floating point comparison. #73

Closed

Conversation

avalentino
Copy link
Contributor

Testing with equality seems to cause issues with new numpy version on debian.
This patch uses numpy.testing.assert_all_close for a safer floating point comparison.

  • Tests added
  • Tests passed
  • Passes git diff origin/main **/*py | flake8 --diff
  • Fully documented

avalentino and others added 3 commits December 22, 2022 11:40
Testing with equality seems to cause issues with new numpy version on debian.
@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Merging #73 (cdc9dcf) into main (5f2cb59) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
+ Coverage   46.61%   46.65%   +0.04%     
==========================================
  Files          15       15              
  Lines        2525     2527       +2     
==========================================
+ Hits         1177     1179       +2     
  Misses       1348     1348              
Impacted Files Coverage Δ
trollsched/tests/test_spherical.py 96.15% <100.00%> (+0.03%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mraspaud
Copy link
Member

The spherical computation are now outsourced to pyresample and the tests have thus been removed. Closing.

@mraspaud mraspaud closed this Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants