Skip to content

Commit

Permalink
Merge pull request #2412 from sfinkens/disable-compression-kwarg
Browse files Browse the repository at this point in the history
  • Loading branch information
mraspaud committed Mar 14, 2023
2 parents 41bf72a + 41226ec commit 29d2c88
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion satpy/tests/writer_tests/test_cf.py
Original file line number Diff line number Diff line change
Expand Up @@ -1450,5 +1450,12 @@ def _get_compression_params(complevel):


def _should_use_compression_keyword():
# xarray currently ignores the "compression" keyword, see
# https://github.com/pydata/xarray/issues/7388. There's already an open
# PR, so we assume that this will be fixed in the next minor release
# (current release is 2023.02). If not, tests will fail and remind us.
versions = _get_backend_versions()
return versions["libnetcdf"] >= Version("4.9.0")
return (
versions["libnetcdf"] >= Version("4.9.0") and
versions["xarray"] >= Version("2023.03")
)

0 comments on commit 29d2c88

Please sign in to comment.