Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add background color option to simple image writer #100

Closed
djhoese opened this issue Nov 15, 2017 · 1 comment
Closed

Add background color option to simple image writer #100

djhoese opened this issue Nov 15, 2017 · 1 comment
Labels
enhancement code enhancements, features, improvements good first issue wontfix

Comments

@djhoese
Copy link
Member

djhoese commented Nov 15, 2017

As mentioned in this thread: https://groups.google.com/forum/#!topic/pytroll/5UuL4jjpm3U

When saving a dataset to a JPEG image (which doesn't support transparency) the default output is a white background. We should provide a keyword argument to the save_dataset of the simple image (PILWriter) writer to do any necessary logic to achieve this. Possible solutions would be to overwrite masked values with the necessary color values. This may have to be added to trollimage.

@djhoese djhoese added enhancement code enhancements, features, improvements help wanted good first issue and removed help wanted labels Nov 15, 2017
@djhoese
Copy link
Member Author

djhoese commented Jun 1, 2021

I don't think this issue makes sense anymore. There is a fill_value parameter which can be set to 0 for a black background or some other value to replace all invalid pixels with that value. Re-reading the linked thread makes me think this is/was an issue with the enhancement that was being used for that data. If someone really wants this feature feel free to comment and tell us about your use case.

@djhoese djhoese closed this as completed Jun 1, 2021
@djhoese djhoese added the wontfix label Jun 1, 2021
adybbroe added a commit to adybbroe/satpy that referenced this issue Dec 2, 2021
…ection

Updated the documentation of inverse Planck function for broad channels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement code enhancements, features, improvements good first issue wontfix
Projects
None yet
Development

No branches or pull requests

1 participant