New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
save_datasets does not save dependencies available due to unload=False #1138
Comments
Just for reference, here are the DatasetIDs in the Scene:
|
Oh! I think this is the code that matters: Lines 1344 to 1345 in 446af3a
The Scene is only going to save the datasets you explicitly requested (the ones on your wishlist). Since in your case everything except |
Additionally, if you'd like to save these, you can specify them in the |
This is a feature not a bug. Only requested datasets will be saved. |
Sorry, one more: This is intended. Most users consider it undesired to have the Scene save things they didn't ask for. Edit: Of course, Martin gets to it first. |
@mraspaud The documentation says otherwise:
Also, if a user didn't ask to keep the dependencies, why would they pass |
Fair enough. I see a point in your use case, so PR is welcome :) |
Describe the bug
When I load a composite with
unload=False
, then runsc.save_datasets
, the datasets loaded as dependencies are not saved.To Reproduce
Expected behavior
I expect:
Actual results
It's actually only writing out one file, so
Number of files found: 1
.Environment Info:
Additional context
There are also a lot of warnings, but I don't think they are related to this problem.
The text was updated successfully, but these errors were encountered: