Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Scene.save_datasets to clarify what will be saved #1864

Merged
merged 1 commit into from Oct 25, 2021

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Oct 22, 2021

@codecov
Copy link

codecov bot commented Oct 22, 2021

Codecov Report

Merging #1864 (da7d133) into main (ab7f3b1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1864   +/-   ##
=======================================
  Coverage   93.17%   93.17%           
=======================================
  Files         270      270           
  Lines       40315    40315           
=======================================
  Hits        37562    37562           
  Misses       2753     2753           
Flag Coverage Δ
behaviourtests 4.65% <ø> (ø)
unittests 93.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/scene.py 92.32% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab7f3b1...da7d133. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.676% when pulling da7d133 on djhoese:doc-save-datasets-wishlist-only into ab7f3b1 on pytroll:main.

Copy link
Collaborator

@gerritholl gerritholl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you for the clarification.

@djhoese djhoese merged commit d9ef2d5 into pytroll:main Oct 25, 2021
@djhoese djhoese deleted the doc-save-datasets-wishlist-only branch October 25, 2021 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

save_datasets does not save dependencies available due to unload=False
3 participants