You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PR #1270 replaces all incorrect usages of self.assertTrue by self.assertEquals, where the latter was clearly the intention. This has lead to test failures in the readers for MERSI2 L1B and VIIRS SDR:
Those tests should have been failing all along, they were erroneously passing due to the erroneous usage of self.assertTrue, so this bug is not new in #1270, it was just unmasked there.
Describe the bug
PR #1270 replaces all incorrect usages of
self.assertTrue
byself.assertEquals
, where the latter was clearly the intention. This has lead to test failures in the readers for MERSI2 L1B and VIIRS SDR:Those tests should have been failing all along, they were erroneously passing due to the erroneous usage of
self.assertTrue
, so this bug is not new in #1270, it was just unmasked there.To Reproduce
self.assertTrue
byself.assertEquals
, such as done in Replace incorrect assertTrue usage in unittests #1270Expected behavior
All tests should pass.
Actual results
Some tests are failing, see above.
Environment Info:
0.22.1.dev48+gdf478972.d20200723
The text was updated successfully, but these errors were encountered: