Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failures in MERSI and VIIRS readers after fixing bugs in test routines #1271

Closed
gerritholl opened this issue Jul 23, 2020 · 0 comments · Fixed by #1270
Closed

Test failures in MERSI and VIIRS readers after fixing bugs in test routines #1271

gerritholl opened this issue Jul 23, 2020 · 0 comments · Fixed by #1270

Comments

@gerritholl
Copy link
Collaborator

Describe the bug

PR #1270 replaces all incorrect usages of self.assertTrue by self.assertEquals, where the latter was clearly the intention. This has lead to test failures in the readers for MERSI2 L1B and VIIRS SDR:

FAILED reader_tests/test_mersi2_l1b.py::TestMERSI2L1BReader::test_fy3d_1km_resolutions - AssertionError: 4 != 2
FAILED reader_tests/test_mersi2_l1b.py::TestMERSI2L1BReader::test_fy3d_250_resolutions - AssertionError: 4 != 2
FAILED reader_tests/test_viirs_sdr.py::TestVIIRSSDRReader::test_init_end_time_beyond - AssertionError: 1 != 0
FAILED reader_tests/test_viirs_sdr.py::TestVIIRSSDRReader::test_init_start_time_beyond - AssertionError: 1 != 0

Those tests should have been failing all along, they were erroneously passing due to the erroneous usage of self.assertTrue, so this bug is not new in #1270, it was just unmasked there.

To Reproduce

Expected behavior

All tests should pass.

Actual results

Some tests are failing, see above.

Environment Info:

  • Satpy Version: 0.22.1.dev48+gdf478972.d20200723
  • Readers and writers dependencies (when relevant): All applicable readers reported ok.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant