Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace incorrect assertTrue usage in unittests #1270

Merged
merged 4 commits into from Jul 29, 2020
Merged

Replace incorrect assertTrue usage in unittests #1270

merged 4 commits into from Jul 29, 2020

Conversation

gerritholl
Copy link
Collaborator

@gerritholl gerritholl commented Jul 23, 2020 •
edited

Multiple places saw incorrect usage of self.assertTrue, where clearly self.assertEqual was meant. A test like self.assertTrue(4, len(scenes)) is going to succeed regardless of the length of scenes.

@gerritholl
Replace incorrect assertTrue usage
0957c58 
Multiple places saw incorrect usage of ``self.assertTrue``, where
clearly ``self.assertEqual`` was meant.  A test like
``self.assertTrue(4, len(scenes))`` is going to succeed regardless of
the length of scenes.
@gerritholl gerritholl mentioned this pull request Jul 23, 2020
Closed
@djhoese djhoese self-assigned this Jul 23, 2020
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 90.034% when pulling 5b89379 on gerritholl:fix-incorrect-assertTrue-usage into 0b986b2 on pytroll:master.

@codecov
Copy link

codecov bot commented Jul 24, 2020 •
edited

Codecov Report

Merging #1270 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1270      +/-   ##
==========================================
+ Coverage   90.00%   90.03%   +0.03%     
==========================================
  Files         218      218              
  Lines       31352    31498     +146     
==========================================
+ Hits        28219    28360     +141     
- Misses       3133     3138       +5
Impacted Files Coverage Δ
satpy/tests/reader_tests/test_acspo.py 100.00% <100.00%> (ø)
satpy/tests/reader_tests/test_agri_l1.py 100.00% <100.00%> (ø)
satpy/tests/reader_tests/test_amsr2_l1b.py 100.00% <100.00%> (ø)
satpy/tests/reader_tests/test_amsr2_l2.py 100.00% <100.00%> (ø)
satpy/tests/reader_tests/test_clavrx.py 100.00% <100.00%> (ø)
satpy/tests/reader_tests/test_geocat.py 100.00% <100.00%> (ø)
satpy/tests/reader_tests/test_glm_l2.py 100.00% <100.00%> (ø)
satpy/tests/reader_tests/test_gpm_imerg.py 100.00% <100.00%> (ø)
satpy/tests/reader_tests/test_grib.py 98.94% <100.00%> (ø)
satpy/tests/reader_tests/test_hy2_scat_l2b_h5.py 100.00% <100.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b986b2...5b89379. Read the comment docs.

@djhoese djhoese merged commit 2b73246 into pytroll:master Jul 29, 2020
@djhoese djhoese changed the title Replace incorrect assertTrue usage Replace incorrect assertTrue usage in unittests Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhoese djhoese Awaiting requested review from djhoese

@mraspaud mraspaud Awaiting requested review from mraspaud

Assignees

@djhoese djhoese

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test failures in MERSI and VIIRS readers after fixing bugs in test routines
3 participants
@gerritholl @coveralls @djhoese