Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update _makedirs in satpy.demo #1289

Closed
raybellwaves opened this issue Aug 2, 2020 · 3 comments · Fixed by #1295
Closed

update _makedirs in satpy.demo #1289

raybellwaves opened this issue Aug 2, 2020 · 3 comments · Fixed by #1295
Labels
cleanup Code cleanup but otherwise no change in functionality refactor

Comments

@raybellwaves
Copy link
Contributor

Given python 2 is dropped
https://satpy.readthedocs.io/en/latest/dev_guide/index.html#coding-guidelines

Could get rid of the comment/code about exist_ok=True and update the _makedirs function

https://github.com/pytroll/satpy/blob/master/satpy/demo/__init__.py#L59L68

@djhoese
Copy link
Member

djhoese commented Aug 3, 2020

Similar to #1293, this could be a good "foot in the door" contribution. What do you think?

@djhoese
Copy link
Member

djhoese commented Aug 3, 2020

@mraspaud I marked this as a bug since we don't really have a "cleanup" label. Maybe we need a cleanup label and a "component:tests" label?

@mraspaud
Copy link
Member

mraspaud commented Aug 6, 2020

Sure!

@djhoese djhoese added cleanup Code cleanup but otherwise no change in functionality and removed bug labels Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code cleanup but otherwise no change in functionality refactor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants