Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ABI mid-latitude cyclone demo downloading wrong number of files #1295

Merged
merged 1 commit into from Aug 6, 2020

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Aug 3, 2020

This fixes a couple issues pointed out about the demo functions. The first is that my glob pattern was a little too relaxed and was picking up newly generated file versions. I'm not really sure how I didn't run into this myself. Second was a workaround for a python 2.7 incompatibility. We don't support python 2 anymore so it could be removed. Lastly, flake8 now complains about function calls inside function definitions so my channels=range(1, 17) was flagged. That was fixed too.

I didn't add any tests for the bug because I'm not really sure how to do that. It all depends on what is actually available on the server and I'd like to avoid contacting GCP every time we run tests.

@djhoese djhoese added the bug label Aug 3, 2020
@djhoese djhoese self-assigned this Aug 3, 2020
@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 90.081% when pulling a8a08f9 on djhoese:bugfix-demo-abi-midlatitude into f80c568 on pytroll:master.

@codecov
Copy link

codecov bot commented Aug 3, 2020

Codecov Report

Merging #1295 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1295   +/-   ##
=======================================
  Coverage   90.07%   90.08%           
=======================================
  Files         218      218           
  Lines       31580    31576    -4     
=======================================
- Hits        28447    28444    -3     
+ Misses       3133     3132    -1     
Impacted Files Coverage Δ
satpy/demo/__init__.py 97.29% <100.00%> (+2.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f80c568...a8a08f9. Read the comment docs.

@djhoese djhoese added the cleanup Code cleanup but otherwise no change in functionality label Aug 6, 2020
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djhoese djhoese merged commit b86b2f7 into pytroll:master Aug 6, 2020
@djhoese djhoese deleted the bugfix-demo-abi-midlatitude branch August 6, 2020 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cleanup Code cleanup but otherwise no change in functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_us_midlatitude_cyclone_abi in satpy.demo fails update _makedirs in satpy.demo
3 participants