Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customes Scene creation from MultiScene.from_files #1399

Closed
gerritholl opened this issue Oct 14, 2020 · 0 comments · Fixed by #1400
Closed

Customes Scene creation from MultiScene.from_files #1399

gerritholl opened this issue Oct 14, 2020 · 0 comments · Fixed by #1400

Comments

@gerritholl
Copy link
Collaborator

Feature Request

Is your feature request related to a problem? Please describe.

MultiScene.from_files is a helpful classmethod to create a MultiScene from files, creating the Scene objects automagically after grouping files (usually) by time. Currently, it creates Scene objects passing only the filenames argument, such that it's not possible to alter how the Scenes are created or what arguments are passed on to the readers with reader_kwargs.

Describe the solution you'd like

I'd like that MultiScene.from_files takes an additional keyword argument scene_kwargs that will be a mapping of keyword arguments passed to the scene creation.

Describe any changes to existing user workflow

New feature will not break any backward compatibility.

Additional context

This proposes YAND (yet another nested dictionary). It's not pretty, but any other solution would probably require a major overhaul. Currently users who need a MultiScene with better customisation of Scene creation can create their Scene objects separately, then combine them into a MultiScene. This may require duplicating some of the work currently done in MultiScene.from_files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant