Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve customisation in multiscene creation #1400

Merged
merged 1 commit into from Oct 23, 2020

Conversation

gerritholl
Copy link
Collaborator

When creating a MultiScene using MultiScene.from_files, allow the user
to pass additional keyword arguments to the Scene creation with the
scene_kwargs keyword argument.

When creating a MultiScene using MultiScene.from_files, allow the user
to pass additional keyword arguments to the Scene creation with the
scene_kwargs keyword argument.
@codecov
Copy link

codecov bot commented Oct 14, 2020

Codecov Report

Merging #1400 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1400   +/-   ##
=======================================
  Coverage   90.56%   90.56%           
=======================================
  Files         228      228           
  Lines       33406    33408    +2     
=======================================
+ Hits        30254    30256    +2     
  Misses       3152     3152           
Impacted Files Coverage Δ
satpy/tests/test_multiscene.py 99.42% <ø> (ø)
satpy/multiscene.py 90.68% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12917ab...ce74650. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 90.535% when pulling ce74650 on gerritholl:multiscene-custom-scene-args into 12917ab on pytroll:master.

@gerritholl
Copy link
Collaborator Author

Can I do anything about the erroneous coveralls report, or is there anything else to do on this PR?

Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've mentioned this before on slack, but I'm not a huge fan of where all these kwargs changes are going, but I'm not sure we have a choice right now either. As is, this PR does what it is meant to do and looks good to me.

@mraspaud mraspaud added component:multiscene enhancement code enhancements, features, improvements labels Oct 23, 2020
@mraspaud mraspaud merged commit e68e858 into pytroll:master Oct 23, 2020
@gerritholl gerritholl deleted the multiscene-custom-scene-args branch October 23, 2020 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:multiscene enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Customes Scene creation from MultiScene.from_files
4 participants