Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Scene.compute to something else #215

Closed
djhoese opened this issue Mar 8, 2018 · 0 comments
Closed

Change Scene.compute to something else #215

djhoese opened this issue Mar 8, 2018 · 0 comments
Assignees
Milestone

Comments

@djhoese
Copy link
Member

djhoese commented Mar 8, 2018

Problem description

The Scene object has a method called compute that goes along with the Scene.load method's compute keyword argument. This method generates any composites that were requested by the user, but aren't currently in the Scene. This is needed when compute=False is passed to Scene.load.

The dask library also uses a .compute method on dask arrays (and xarrays backed by dask arrays). I propose that the Scene.compute method and the associated keyword should be renamed to something else to avoid confusion. Especially since we may want to include a compute method on the Scene in the future that computes all datasets in the Scene.

Possible method names and keyword argument names (please contribute):

  • generate_composites/generate
  • composite / composite
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants