Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-requested datasets are saved when composites fail to generate #332

Closed
djhoese opened this issue Jun 23, 2018 · 0 comments · Fixed by #342
Closed

Non-requested datasets are saved when composites fail to generate #332

djhoese opened this issue Jun 23, 2018 · 0 comments · Fixed by #342

Comments

@djhoese
Copy link
Member

djhoese commented Jun 23, 2018

Describe the bug

Right now the Scene objects save_datasets method defaults to saving all currently loaded/existing datasets. This means that if a composite hasn't been generated yet, either by generate=False or IncompatibleAreas or some unexpected failure then scn.save_datasets() will save dependency datasets that weren't actually requested by the user. This can be very confusing.

To Reproduce

scn = Scene(reader='abi_l1b', filenames=[...])
scn.load(['true_color'])
scn.save_datasets()

Expected behavior

Only true_color would be saved if it exists or it won't be saved. Optionally it could raise an exception if none of the requested datasets (Scene.wishlist) are available to save.

Actual results

C01, C02, C03, etc. geotiffs will be saved.

Screenshots
If applicable, add screenshots to help explain your problem.

Environment Info:

  • OS: [e.g. OSX, Windows, Linux]
  • SatPy Version: [e.g. 0.9.0]
  • PyResample Version:

Additional context
Add any other context about the problem here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant