Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Scene save_datasets to only save datasets from the wishlist #342

Merged
merged 1 commit into from Jun 28, 2018

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Jun 28, 2018

See the associated issue for more details. Basically if you have datasets in your Scene that were not manually added or and aren't in the wishlist (ex. composite prerequisites) then calling save_datasets would save those datasets too which is unexpected. Now a RuntimeError is raised.

@coveralls
Copy link

coveralls commented Jun 28, 2018

Coverage Status

Coverage increased (+0.02%) to 69.153% when pulling 8f31507 on djhoese:bugfix-save-datasets into 9767550 on pytroll:master.

@codecov
Copy link

codecov bot commented Jun 28, 2018

Codecov Report

Merging #342 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #342      +/-   ##
==========================================
+ Coverage   69.12%   69.15%   +0.02%     
==========================================
  Files         123      123              
  Lines       15636    15645       +9     
==========================================
+ Hits        10809    10819      +10     
+ Misses       4827     4826       -1
Impacted Files Coverage Δ
satpy/scene.py 85.08% <100%> (+0.31%) ⬆️
satpy/tests/test_scene.py 99.31% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9767550...8f31507. Read the comment docs.

@djhoese djhoese merged commit 9324bf5 into pytroll:master Jun 28, 2018
@djhoese djhoese deleted the bugfix-save-datasets branch June 28, 2018 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-requested datasets are saved when composites fail to generate
2 participants