Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename standard_name for various readers to be consistent #1006

Merged
merged 1 commit into from Dec 10, 2019

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Dec 6, 2019

Found out that AVHRR had incorrect standard_name from a mailing list issue. While fixing it I found that a couple readers had this issue.

  • Tests added and test suite added to parent suite
  • Tests passed
  • Passes flake8 satpy

Copy link
Member

@sfinkens sfinkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this!

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 86.923% when pulling 905d2e4 on djhoese:bugfix-avhrr-standard-names into 8ded572 on pytroll:master.

@codecov
Copy link

codecov bot commented Dec 6, 2019

Codecov Report

Merging #1006 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1006      +/-   ##
==========================================
+ Coverage   86.92%   86.92%   +<.01%     
==========================================
  Files         181      181              
  Lines       27553    27553              
==========================================
+ Hits        23950    23951       +1     
+ Misses       3603     3602       -1
Impacted Files Coverage Δ
satpy/scene.py 90.53% <0%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ded572...905d2e4. Read the comment docs.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud merged commit c30ba98 into pytroll:master Dec 10, 2019
@djhoese djhoese deleted the bugfix-avhrr-standard-names branch January 6, 2020 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants