Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide only dask arrays to pyspectral's nir reflectance computation #1011

Merged
merged 1 commit into from Dec 16, 2019

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Dec 10, 2019

As pyspectral doesn't officially support xr.DataArrays, and with observing that passing DataArrays affects performance badly, this PR changes the call pyspectral's NIR reflectance calculator to dask-only.

  • Tests added and test suite added to parent suite
  • Tests passed
  • Passes flake8 satpy

@mraspaud mraspaud self-assigned this Dec 10, 2019
@mraspaud mraspaud added component:compositors enhancement code enhancements, features, improvements labels Dec 10, 2019
@coveralls
Copy link

Coverage Status

Coverage increased (+0.0009%) to 87.204% when pulling 68583a9 on mraspaud:fix-nir-dask into e8f3518 on pytroll:master.

@codecov
Copy link

codecov bot commented Dec 10, 2019

Codecov Report

Merging #1011 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1011      +/-   ##
=========================================
+ Coverage    87.2%   87.2%   +<.01%     
=========================================
  Files         181     181              
  Lines       27890   27892       +2     
=========================================
+ Hits        24321   24323       +2     
  Misses       3569    3569
Impacted Files Coverage Δ
satpy/composites/__init__.py 78.41% <100%> (+0.05%) ⬆️
satpy/tests/compositor_tests/__init__.py 99.58% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8f3518...68583a9. Read the comment docs.

@mraspaud
Copy link
Member Author

@djhoese @adybbroe does anyone want to quickly review this ? It's just making sure pure dask arrays are passed to pyspectral, and is linked to pytroll/pyspectral#97

@mraspaud mraspaud merged commit 8be2ff1 into pytroll:master Dec 16, 2019
@mraspaud mraspaud deleted the fix-nir-dask branch December 16, 2019 08:26
Copy link
Contributor

@adybbroe adybbroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't see anything alarming or wrong here...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:compositors enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants