Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a small cviirs speedup #1012

Merged
merged 1 commit into from Dec 11, 2019

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Dec 10, 2019

This is a minor improvement to the cviirs reader, which helps in case of slow IO

  • Tests passed
  • Passes flake8 satpy

@mraspaud mraspaud added enhancement code enhancements, features, improvements component:readers labels Dec 10, 2019
@mraspaud mraspaud self-assigned this Dec 10, 2019
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.002%) to 87.201% when pulling f474e24 on mraspaud:feature-small-cviirs-speedup into e8f3518 on pytroll:master.

@codecov
Copy link

codecov bot commented Dec 10, 2019

Codecov Report

Merging #1012 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1012      +/-   ##
=========================================
- Coverage    87.2%   87.2%   -0.01%     
=========================================
  Files         181     181              
  Lines       27890   27893       +3     
=========================================
+ Hits        24321   24323       +2     
- Misses       3569    3570       +1
Impacted Files Coverage Δ
satpy/readers/viirs_compact.py 64.98% <100%> (+0.41%) ⬆️
satpy/scene.py 90.35% <0%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8f3518...f474e24. Read the comment docs.

@mraspaud mraspaud merged commit fb61664 into pytroll:master Dec 11, 2019
@mraspaud mraspaud deleted the feature-small-cviirs-speedup branch December 11, 2019 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants