Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SCMI writer and VIIRS EDR Flood reader to work for pre-tiled data #1027

Merged
merged 13 commits into from Jan 6, 2020

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Dec 30, 2019

This is functionality needed by some folks at the SSEC as a proof of concept to get VIIRS EDR Flood data in to AWIPS. The files generated by their software is a composite of ABI and VIIRS data in to individual latlong tiles (15 degrees by 15 degrees each). These files and their naming scheme was not previously supported by the viirs_edr_flood reader. That is one of the features this PR adds.

For the SCMI writer, while working with this new data I noticed that the SCMI writer was needlessly creating "extra" tiles. This was mostly floating point error where the writer was determining that we needed to "shift" the current grid of tiles over by ~1e-15 pixels. This ends up resulting in a 1 pixel shift that isn't needed. This was fixed in this PR.

The remaining TODO for this PR (at the time of writing) is to make it so generated tile files can be "updated" by additional executions. This is needed for the way the ABI/VIIRS composites are generated with 15x15 degree tiles. We need to process one tile, generate the AWIPS tiles, process the next input tile, and update any of the "missing" space in the previous generated tiles.

  • Tests added and test suite added to parent suite
  • Tests passed
  • Passes flake8 satpy
  • Fully documented

@djhoese djhoese added enhancement code enhancements, features, improvements component:readers component:writers labels Dec 30, 2019
@djhoese djhoese self-assigned this Dec 30, 2019
@coveralls
Copy link

coveralls commented Dec 30, 2019

Coverage Status

Coverage decreased (-0.07%) to 87.272% when pulling e85979e on djhoese:feature-scmi-longlat into be0dd61 on pytroll:master.

@codecov
Copy link

codecov bot commented Dec 30, 2019

Codecov Report

Merging #1027 into master will decrease coverage by 0.09%.
The diff coverage is 73.72%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1027     +/-   ##
=========================================
- Coverage   87.37%   87.27%   -0.1%     
=========================================
  Files         183      188      +5     
  Lines       28181    28739    +558     
=========================================
+ Hits        24622    25081    +459     
- Misses       3559     3658     +99
Impacted Files Coverage Δ
satpy/tests/writer_tests/test_scmi.py 98.38% <100%> (+1.29%) ⬆️
satpy/readers/utils.py 79.56% <100%> (ø) ⬆️
satpy/writers/scmi.py 72.41% <65.55%> (-2.02%) ⬇️
satpy/resample.py 90.61% <0%> (-2.37%) ⬇️
satpy/readers/olci_nc.py 90% <0%> (-0.91%) ⬇️
satpy/scene.py 89.63% <0%> (-0.91%) ⬇️
satpy/composites/__init__.py 78.96% <0%> (-0.03%) ⬇️
satpy/readers/seviri_l1b_icare.py 84.55% <0%> (ø)
satpy/readers/mimic_TPW2_nc.py 90% <0%> (ø)
satpy/tests/reader_tests/test_seviri_l1b_icare.py 95.41% <0%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7235fbc...e85979e. Read the comment docs.

@djhoese djhoese marked this pull request as ready for review January 3, 2020 18:05
@djhoese djhoese requested a review from mraspaud as a code owner January 3, 2020 18:05
@djhoese
Copy link
Member Author

djhoese commented Jan 3, 2020

@mraspaud This is ready for review, but as mentioned in #1028 one of the mitiff tests is failing and seems unrelated to my changes. I am unable to reproduce the failure locally it seems.

@djhoese
Copy link
Member Author

djhoese commented Jan 6, 2020

I talked with @mraspaud on slack. Ok with this being merged given the important CI bug fixes and that the SCMI and VIIRS EDR Flood changes shouldn't effect other parts of Satpy.

@djhoese djhoese merged commit c80a510 into pytroll:master Jan 6, 2020
@djhoese djhoese deleted the feature-scmi-longlat branch January 6, 2020 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers component:writers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants