Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tropomi_l2 reader not using y and x dimension names #1031

Merged
merged 1 commit into from Jan 8, 2020

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Jan 6, 2020

sateesh (can't find github username) on slack pointed out that the tropomi_l2 reader can't be resampled. It fails with the error:

ValueError: cannot add coordinates with new dimensions to a DataArray

This was caused by the reader producing data that didn't include the y and x dimensions and instead was using the file's original dimensions scanline and ground_pixel. From what I can tell we don't mention this in the custom reader documentation. I'll make a separate issue or PR for that.

  • Tests added and test suite added to parent suite
  • Tests passed
  • Passes flake8 satpy

@coveralls
Copy link

Coverage Status

Coverage increased (+0.005%) to 87.28% when pulling c15b72a on djhoese:bugfix-tropomi-dim-names into c80a510 on pytroll:master.

@codecov
Copy link

codecov bot commented Jan 7, 2020

Codecov Report

Merging #1031 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1031      +/-   ##
==========================================
+ Coverage   87.27%   87.28%   +<.01%     
==========================================
  Files         188      188              
  Lines       28739    28751      +12     
==========================================
+ Hits        25082    25094      +12     
  Misses       3657     3657
Impacted Files Coverage Δ
satpy/tests/reader_tests/test_tropomi_l2.py 94.05% <100%> (+0.24%) ⬆️
satpy/readers/tropomi_l2.py 94.87% <100%> (+0.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c80a510...c15b72a. Read the comment docs.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants