Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AMI geolocation being off by 1 pixel #1034

Merged
merged 3 commits into from Jan 8, 2020

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Jan 7, 2020

I noticed when working with AMI L1b data that the geolocation for a full disk image was not square. Turns out I had a +/- bug in the math for the area extents. This PR fixes this.

  • Tests added and test suite added to parent suite
  • Tests passed
  • Passes flake8 satpy

CC @simonrp84

@codecov
Copy link

codecov bot commented Jan 7, 2020

Codecov Report

Merging #1034 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1034      +/-   ##
==========================================
- Coverage   87.27%   87.26%   -0.01%     
==========================================
  Files         188      188              
  Lines       28739    28735       -4     
==========================================
- Hits        25082    25077       -5     
- Misses       3657     3658       +1
Impacted Files Coverage Δ
satpy/tests/reader_tests/test_ami_l1b.py 94.73% <ø> (ø) ⬆️
satpy/readers/_geos_area.py 100% <100%> (ø) ⬆️
satpy/readers/ami_l1b.py 97.39% <100%> (-0.09%) ⬇️
satpy/scene.py 89.63% <0%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c80a510...c58223c. Read the comment docs.

@coveralls
Copy link

coveralls commented Jan 7, 2020

Coverage Status

Coverage decreased (-0.005%) to 87.27% when pulling c58223c on djhoese:bugfix-ami-geo into c80a510 on pytroll:master.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud merged commit f297e33 into pytroll:master Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants