Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional Sentinel 3 OLCI 2 datasets #1035

Merged
merged 3 commits into from Jan 10, 2020
Merged

Add additional Sentinel 3 OLCI 2 datasets #1035

merged 3 commits into from Jan 10, 2020

Conversation

johannesocean
Copy link
Contributor

@johannesocean johannesocean commented Jan 8, 2020

This PR adds the following datasets to the olci l2 reader:

iop_nn (cdm_absorption_coefficient)
trsp (diffuse_attenuation_coefficient)
tsm_nn (total_suspended_matter_concentration)

  • Tests passed
  • Add your name to AUTHORS.md if not there already

iop_nn (cdm_absorption_coefficient)
trsp (diffuse_attenuation_coefficient)
tsm_nn (total_suspended_matter_concentration)
@coveralls
Copy link

coveralls commented Jan 8, 2020

Coverage Status

Coverage increased (+0.02%) to 87.29% when pulling 42237e6 on JohannesSMHI:feature-new-olci_2-datasets into 2f9501e on pytroll:master.

@codecov
Copy link

codecov bot commented Jan 8, 2020

Codecov Report

Merging #1035 into master will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1035      +/-   ##
==========================================
+ Coverage   87.29%   87.42%   +0.13%     
==========================================
  Files         188      188              
  Lines       28742    29033     +291     
==========================================
+ Hits        25089    25383     +294     
+ Misses       3653     3650       -3
Impacted Files Coverage Δ
satpy/tests/writer_tests/test_cf.py 98.64% <0%> (+0.14%) ⬆️
satpy/tests/reader_tests/test_abi_l1b.py 97.41% <0%> (+0.19%) ⬆️
satpy/tests/reader_tests/test_glm_l2.py 96.42% <0%> (+1.55%) ⬆️
satpy/tests/reader_tests/test_abi_l2_nc.py 96.33% <0%> (+2.48%) ⬆️
satpy/writers/cf_writer.py 93.19% <0%> (+2.51%) ⬆️
satpy/readers/abi_base.py 91.6% <0%> (+3.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f9501e...42237e6. Read the comment docs.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud added component:readers enhancement code enhancements, features, improvements labels Jan 10, 2020
@mraspaud mraspaud merged commit 2485b0b into pytroll:master Jan 10, 2020
@djhoese djhoese changed the title Sentinel 3 olci_2 - new datasets Add additional Sentinel 3 OLCI 2 datasets Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants