Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify Dataset attribute naming in SEVIRI L2 BUFR-reader #1041

Merged
merged 1 commit into from Jan 14, 2020
Merged

Unify Dataset attribute naming in SEVIRI L2 BUFR-reader #1041

merged 1 commit into from Jan 14, 2020

Conversation

sjoro
Copy link
Collaborator

@sjoro sjoro commented Jan 14, 2020

Unify Dataset attribute naming in SEVIRI L2 BUFR-reader to match other Satpy readers. Change satellite_name to platform_name.

  • Tests passed
  • Passes flake8 satpy

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.338% when pulling 8c356b5 on sjoro:unify_attrs into 84c74be on pytroll:master.

@codecov
Copy link

codecov bot commented Jan 14, 2020

Codecov Report

Merging #1041 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1041   +/-   ##
=======================================
  Coverage   87.34%   87.34%           
=======================================
  Files         188      188           
  Lines       28770    28770           
=======================================
  Hits        25128    25128           
  Misses       3642     3642
Impacted Files Coverage Δ
satpy/tests/reader_tests/test_seviri_l2_bufr.py 93.65% <100%> (ø) ⬆️
satpy/readers/seviri_l2_bufr.py 92.18% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84c74be...8c356b5. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants