Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set travis and appveyor numpy version back to 'stable' #1044

Merged
merged 2 commits into from Mar 25, 2020

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Jan 20, 2020

The ci-helpers default for "stable" numpy version is 1.18 which is not available from conda-forge. This was causing problems in #988 but maybe now that I fixed the mitiff issue this will work (even if ci-helpers falls back to PyPI numpy).

  • Tests passed

@djhoese djhoese self-assigned this Jan 20, 2020
@coveralls
Copy link

coveralls commented Jan 20, 2020

Coverage Status

Coverage decreased (-0.003%) to 89.464% when pulling fc109a3 on djhoese:ci-numpy-version into 8ffb6ec on pytroll:master.

@mraspaud
Copy link
Member

@djhoese this is good to merge, right ?

@mraspaud mraspaud added the enhancement code enhancements, features, improvements label Mar 25, 2020
@mraspaud mraspaud added this to the v0.21.0 milestone Mar 25, 2020
@djhoese
Copy link
Member Author

djhoese commented Mar 25, 2020

OSX is failing. I've restarted those environments.

@djhoese
Copy link
Member Author

djhoese commented Mar 25, 2020

It seems like the failure is related to the pygrib, glymur, and pygac dependencies not being installed.

@codecov
Copy link

codecov bot commented Mar 25, 2020

Codecov Report

Merging #1044 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1044   +/-   ##
=======================================
  Coverage   89.46%   89.46%           
=======================================
  Files         198      198           
  Lines       29157    29157           
=======================================
  Hits        26086    26086           
  Misses       3071     3071

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ffb6ec...fc109a3. Read the comment docs.

@ghost
Copy link

ghost commented Mar 25, 2020

Congratulations 🎉. DeepCode analyzed your code in 0.136 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard

@djhoese
Copy link
Member Author

djhoese commented Mar 25, 2020

Merged with master which already had travis on stable numpy and was passing. Now github missed the travis link so here is the latest build for this PR: https://travis-ci.org/github/pytroll/satpy/builds/666786469

@mraspaud
Copy link
Member

Ok, good, this can be merged when it passes

@djhoese djhoese merged commit f306388 into pytroll:master Mar 25, 2020
@djhoese djhoese deleted the ci-numpy-version branch March 25, 2020 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants