Fix handling of paths with forward slashes on Windows #1049
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed with the UW SIFT application that paths returned by the file dialog (Qt5) always had forward slashes, even on Windows. This is expected behavior by Qt5. These forward slashes were causing Satpy to not recognize any of the filenames. While I could workaround this in SIFT, Satpy has other users in the past with this issue. I always thought this was a user problem, but now that I find out some applications/frameworks like Qt5 create paths like this, I think Satpy should have the fix.
The one thing I don't like about this PR is that it adds an extra step to
get_filebase
which is used multiple times in the reader loading process. I'm not sure if it is "better" to move this operation higher up in the reader loading functions for not. Additionally, I notice thatmatch_filenames
creates a list instead of returning a generator. It doesn't seem necessary to do this so I might change that too (feedback welcome).flake8 satpy