Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sst standard name #1055

Merged
merged 3 commits into from Feb 3, 2020
Merged

Conversation

eysteinn
Copy link
Contributor

@eysteinn eysteinn commented Feb 3, 2020

Fix error in standard_name for quality_level in Sentinel-3 slstr_l2 reader

Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Too bad there isn't a real CF standard name for this value.

@mraspaud
Copy link
Member

mraspaud commented Feb 3, 2020

Would this be status flags like this ? http://cfconventions.org/Data/cf-conventions/cf-conventions-1.7/build/ch03s05.html

@eysteinn
Copy link
Contributor Author

eysteinn commented Feb 3, 2020

I'm using the internal variable names as they appear in the nc file

@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 88.081% when pulling 5522180 on eysteinn:fix_sst_standard_name into 6b0959e on pytroll:master.

@codecov
Copy link

codecov bot commented Feb 3, 2020

Codecov Report

Merging #1055 into master will increase coverage by 0.53%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1055      +/-   ##
==========================================
+ Coverage   87.55%   88.09%   +0.53%     
==========================================
  Files         190      191       +1     
  Lines       29324    29431     +107     
==========================================
+ Hits        25676    25927     +251     
+ Misses       3648     3504     -144     
Impacted Files Coverage Δ
satpy/tests/reader_tests/test_aapp_l1b.py 100.00% <0.00%> (ø)
satpy/tests/reader_tests/test_seviri_l2_bufr.py 94.11% <0.00%> (+0.36%) ⬆️
satpy/readers/seviri_l2_bufr.py 93.90% <0.00%> (+1.36%) ⬆️
satpy/readers/aapp_l1b.py 86.27% <0.00%> (+71.91%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 704d831...5522180. Read the comment docs.

@mraspaud
Copy link
Member

mraspaud commented Feb 3, 2020

Ok, that's reasonable.

@mraspaud mraspaud merged commit 24d5bdb into pytroll:master Feb 3, 2020
@mraspaud mraspaud added the bug label Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants