Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix name of natural_color composite in quickstart #1056

Merged
merged 1 commit into from Feb 5, 2020
Merged

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Feb 3, 2020

As discussed on slack, the quick start document uses old composite names.

  • Fully documented

@djhoese djhoese self-assigned this Feb 3, 2020
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djhoese
Copy link
Member Author

djhoese commented Feb 3, 2020

@mraspaud As you've noticed in other PRs, the tests are failing. One failure I see is our use of func that is passed to Xarray's coarsen. The func keyword doesn't seem to have ever existed. It is called coord_func. However, I don't understand how this wasn't found before. It's been this way for many versions. Or maybe it is just supposed to be passed as a positional argument: https://github.com/pydata/xarray/pull/3500/files#diff-3fbfbfa64dfac6984aaa9d3925bf57beL1867

@mraspaud
Copy link
Member

mraspaud commented Feb 4, 2020

Interesting...

@mraspaud mraspaud merged commit fbefad6 into master Feb 5, 2020
@djhoese djhoese deleted the djhoese-patch-1 branch February 2, 2022 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants