Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AHI airmass, ash, dust, fog, and night_microphysics RGBs #1065

Merged
merged 1 commit into from Feb 12, 2020

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Feb 10, 2020

The RGBs added in this pull request are common EUMETSAT recipes that are available for most other sensors. However, AHI doesn't have a 10.8um or a 12.0um channel (or channels whose ranges cover those wavelengths). This is my attempt at trying to balance all the information available for what the best AHI RGB recipes are. I've mostly taken this from various slides by JMA found by googling, from opinions by @ScottLindstrom at the SSEC which agreed with the JMA slides, and from existing ABI recipes. See ssec/polar2grid#258 for more discussion on this and why I'm doing it (to add them to CSPP Geo Geo2Grid).

The worst thing is I can't find a definitive guide for AHI recipes. The slides from conferences that I've found (2016 and 2017) are completely different from the training materials (2015?) which are also different from ABI recipes out there.

Note: None of these recipes were loadable for AHI data before this PR so this shouldn't be changing any existing functionality for users.

  • Tests passed
  • Passes flake8 satpy
  • Fully documented

Examples

Airmass

airmass_20181022_030019

Ash

ash_20181022_030019

Dust

dust_20181022_030019

Fog

fog_20181022_030019

Night Microphysics

night_microphysics_20181022_030019

@djhoese djhoese added enhancement code enhancements, features, improvements component:compositors labels Feb 10, 2020
@djhoese djhoese added this to the v0.20.0 milestone Feb 10, 2020
@djhoese djhoese self-assigned this Feb 10, 2020
@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.097% when pulling 7a3241a on djhoese:feature-ahi-rgbs into fbefad6 on pytroll:master.

@codecov
Copy link

codecov bot commented Feb 10, 2020

Codecov Report

Merging #1065 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1065   +/-   ##
=======================================
  Coverage   88.09%   88.09%           
=======================================
  Files         191      191           
  Lines       29439    29439           
=======================================
  Hits        25935    25935           
  Misses       3504     3504

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbefad6...7a3241a. Read the comment docs.

@djhoese
Copy link
Member Author

djhoese commented Feb 12, 2020

Here are some night examples. I noticed some odd artifacts in the night_microphysics but I think that is just in the data. Note these pictures are 10% the resolution of the original so the effect is made more apparent. I'll investigate this next.

Airmass

airmass_20181022_170019

Ash

ash_20181022_170019

Dust

dust_20181022_170019

Fog

fog_20181022_170019

Night Microphysics

night_microphysics_20181022_170019

@djhoese
Copy link
Member Author

djhoese commented Feb 12, 2020

Yep this is the B07 having bad data in it:

Screenshot_20200212_121627

@mraspaud If the night_microphysics looks OK to you otherwise I think this is good to go.

@ScottLindstrom
Copy link

That doesn't look like bad B07 data to me, rather it's a manifestation of the poor precision of B07 at very cold cloud top temperatures. So a single radiance value might span several tenths of degrees at cold temperatures. Thus you get speckled values. All of the RGBs look reasonable to me, although I don't see a lot of obvious fog in the NightTime microphysics but that might be a function of the weather on that day.

@djhoese
Copy link
Member Author

djhoese commented Feb 12, 2020

I got approval from @mraspaud on slack. Merging now...

@djhoese djhoese merged commit b77846e into pytroll:master Feb 12, 2020
@djhoese djhoese deleted the feature-ahi-rgbs branch February 12, 2020 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:compositors enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants