Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GOES-17 support to the 'geocat' reader #1067

Merged
merged 2 commits into from Feb 12, 2020

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Feb 10, 2020

The 'geocat' group at the SSEC is now working on producing files operationally with GOES-17 data. I had hacked something together for GOES-16, but forgot to include GOES-17. This extends the hack to support GOES-17 until geocat adds projection information to their files (possibly in the future?).

  • Tests added and test suite added to parent suite
  • Tests passed
  • Passes flake8 satpy

@djhoese djhoese added enhancement code enhancements, features, improvements component:readers labels Feb 10, 2020
@djhoese djhoese self-assigned this Feb 10, 2020
@djhoese djhoese added this to the v0.20.0 milestone Feb 10, 2020
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 88.112% when pulling b4e33b9 on djhoese:bugfix-geocat-g17 into fbefad6 on pytroll:master.

@codecov
Copy link

codecov bot commented Feb 10, 2020

Codecov Report

Merging #1067 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1067      +/-   ##
==========================================
+ Coverage   88.09%   88.11%   +0.01%     
==========================================
  Files         191      191              
  Lines       29439    29450      +11     
==========================================
+ Hits        25935    25949      +14     
+ Misses       3504     3501       -3
Impacted Files Coverage Δ
satpy/readers/geocat.py 88.46% <ø> (+0.64%) ⬆️
satpy/tests/reader_tests/test_geocat.py 100% <100%> (+3.03%) ⬆️
satpy/scene.py 89.73% <0%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbefad6...b4e33b9. Read the comment docs.

@djhoese
Copy link
Member Author

djhoese commented Feb 12, 2020

Got slack approval from @mraspaud. Merging...

@djhoese djhoese merged commit e55749f into pytroll:master Feb 12, 2020
@djhoese djhoese deleted the bugfix-geocat-g17 branch February 12, 2020 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants