Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SLSTR composites #1082

Merged
merged 3 commits into from Feb 25, 2020
Merged

Update SLSTR composites #1082

merged 3 commits into from Feb 25, 2020

Conversation

simonrp84
Copy link
Member

This PR adds:

  1. A new natural_color composite for SLSTR that uses the 0.6, 0.8 and 1.6 micron bands.
  2. Composites for the oblique view. natural_color and overview. Previously, overview was for nadir only.

This only changes the yaml file, no changes to the python code are needed.

@mraspaud
Copy link
Member

Thanks for the PR. @djhoese did we decide that overview and natural_colors should be sunz corrected by default ?

@djhoese
Copy link
Member

djhoese commented Feb 24, 2020

Yes I think so. sunz if possible, rayleigh correction if possible. At least that's what we've done for VIIRS, ABI, and I think SEVIRI.

@coveralls
Copy link

coveralls commented Feb 24, 2020

Coverage Status

Coverage increased (+0.03%) to 88.928% when pulling 57b2675 on simonrp84:slstr-composites into ca8595f on pytroll:master.

@codecov
Copy link

codecov bot commented Feb 24, 2020

Codecov Report

Merging #1082 into master will increase coverage by 0.04%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1082      +/-   ##
==========================================
+ Coverage   88.89%   88.94%   +0.04%     
==========================================
  Files         192      194       +2     
  Lines       29657    29823     +166     
==========================================
+ Hits        26364    26525     +161     
- Misses       3293     3298       +5
Impacted Files Coverage Δ
satpy/readers/slstr_l1b.py 63.94% <25%> (+0.85%) ⬆️
satpy/readers/tropomi_l2.py 94.11% <0%> (-1.01%) ⬇️
satpy/scene.py 89.73% <0%> (-0.18%) ⬇️
satpy/tests/reader_tests/test_iasi_l2_so2_bufr.py 96.15% <0%> (ø)
satpy/readers/iasi_l2_so2_bufr.py 94.44% <0%> (ø)
satpy/tests/reader_tests/__init__.py 98.5% <0%> (+0.02%) ⬆️
satpy/writers/ninjotiff.py 60% <0%> (+0.62%) ⬆️
satpy/tests/writer_tests/test_ninjotiff.py 100% <0%> (+2.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca8595f...57b2675. Read the comment docs.

@mraspaud mraspaud added component:compositors enhancement code enhancements, features, improvements labels Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:compositors enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants