Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add latitude_bounds and longitude_bounds to tropomi_l2 #1084

Merged
merged 2 commits into from Feb 25, 2020

Conversation

zxdawn
Copy link
Member

@zxdawn zxdawn commented Feb 25, 2020

Add latitude_bounds and longitude_bounds to tropomi_l2 reader.

KNMI researchers usually use these two variables to plot data. I've compared the differences of using longitude /latitude and latitude_bounds/longitude_bounds. Details are posted on my blog. The difference is ~ half pixel.

@zxdawn zxdawn changed the title add latitude_bounds and longitude_bounds add latitude_bounds and longitude_bounds to tropomi_l2 Feb 25, 2020
@coveralls
Copy link

coveralls commented Feb 25, 2020

Coverage Status

Coverage increased (+0.001%) to 88.894% when pulling 48f47a6 on zxdawn:tropomi into ca8595f on pytroll:master.

@codecov
Copy link

codecov bot commented Feb 25, 2020

Codecov Report

Merging #1084 into master will decrease coverage by <.01%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1084      +/-   ##
==========================================
- Coverage   88.89%   88.89%   -0.01%     
==========================================
  Files         192      192              
  Lines       29657    29660       +3     
==========================================
+ Hits        26364    26366       +2     
- Misses       3293     3294       +1
Impacted Files Coverage Δ
satpy/readers/tropomi_l2.py 94.11% <75%> (-1.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca8595f...48f47a6. Read the comment docs.

@mraspaud
Copy link
Member

Could you explain why this change to the code is needed ?

@zxdawn
Copy link
Member Author

zxdawn commented Feb 25, 2020

@mraspaud For example, lat_shape is 1 x 373 x 450 and the shape of latitude_bounds is 1 x 373 x 450 x 4. So, that if statement would ignore latitude_bounds and longitude_bounds.

@mraspaud mraspaud changed the title add latitude_bounds and longitude_bounds to tropomi_l2 Add latitude_bounds and longitude_bounds to tropomi_l2 Feb 25, 2020
@mraspaud mraspaud added the bug label Feb 25, 2020
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud merged commit 29ac184 into pytroll:master Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants