Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sunz correction use available sunz dataset #1089

Merged
merged 5 commits into from Mar 26, 2020

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Feb 27, 2020

I noticed that the sun zenith angles being an optional dataset, it was never used by the SunZenithCorrector. This PR fixes the issue.

  • Tests added and test suite added to parent suite
  • Tests passed
  • Passes flake8 satpy
  • Fully documented

@mraspaud mraspaud self-assigned this Feb 27, 2020
@mraspaud mraspaud added this to the v0.21.0 milestone Mar 25, 2020
@ghost
Copy link

ghost commented Mar 25, 2020

DeepCode's analysis on #3a29b0 found:

1 minor issue. ✔️ 1 issue were fixed.

👉 View analysis in DeepCode’s Dashboard

☺️ If you want to provide feedback on our bot, here is how to contact us.

@mraspaud mraspaud marked this pull request as ready for review March 25, 2020 09:39
@mraspaud mraspaud requested a review from djhoese as a code owner March 25, 2020 09:39
@codecov
Copy link

codecov bot commented Mar 25, 2020

Codecov Report

Merging #1089 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1089      +/-   ##
==========================================
+ Coverage   89.43%   89.46%   +0.02%     
==========================================
  Files         198      198              
  Lines       29033    29167     +134     
==========================================
+ Hits        25965    26093     +128     
- Misses       3068     3074       +6     
Impacted Files Coverage Δ
satpy/composites/__init__.py 78.37% <100.00%> (-0.30%) ⬇️
satpy/tests/test_composites.py 100.00% <100.00%> (ø)
satpy/readers/tropomi_l2.py 90.00% <0.00%> (-4.12%) ⬇️
satpy/tests/writer_tests/test_mitiff.py 99.10% <0.00%> (+0.13%) ⬆️
satpy/writers/mitiff.py 91.80% <0.00%> (+0.14%) ⬆️
satpy/writers/__init__.py 86.50% <0.00%> (+0.48%) ⬆️
satpy/tests/reader_tests/test_tropomi_l2.py 98.36% <0.00%> (+0.63%) ⬆️
satpy/config.py 83.47% <0.00%> (+1.32%) ⬆️
satpy/tests/test_config.py 91.13% <0.00%> (+1.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b71a90...3a29b05. Read the comment docs.

@coveralls
Copy link

coveralls commented Mar 25, 2020

Coverage Status

Coverage increased (+0.03%) to 89.461% when pulling 3a29b05 on mraspaud:fix-sunz-correction-computation into 7b71a90 on pytroll:master.

@mraspaud mraspaud merged commit 6c11402 into pytroll:master Mar 26, 2020
@mraspaud mraspaud deleted the fix-sunz-correction-computation branch March 26, 2020 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants