Add sensor-name property to NWCSAF readers

[adybbroe]

Add the sensor name as a property to the NWCSAF/Geo&PPS readers

• Closes Loading both abi and nwcsaf-geo confuses satpy into sometimes trying the wrong composite #1112, closes Add more sats support in nwcsaf-geo reader #1111
• Tests added
• Tests passed
• Passes flake8 satpy
• Fully documented
• Add your name to AUTHORS.md if not there already

[coveralls]

Coverage decreased (-0.008%) to 89.327% when pulling 8c8815c on adybbroe:fix-sensor-name-nwcsaf-readers into e91b6c7 on pytroll:master.

[codecov]

Codecov Report

Merging #1113 into master will decrease coverage by <.01%.
The diff coverage is 94.59%.

@@            Coverage Diff             @@
##           master    #1113      +/-   ##
==========================================
- Coverage   89.33%   89.33%   -0.01%     
==========================================
  Files         195      195              
  Lines       28796    28827      +31     
==========================================
+ Hits        25726    25753      +27     
- Misses       3070     3074       +4

Impacted Files	Coverage Δ
satpy/tests/reader_tests/test_nwcsaf_nc.py	100% <100%> (ø)	⬆️
satpy/readers/nwcsaf_nc.py	54.83% <87.5%> (+0.29%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e91b6c7...8c8815c. Read the comment docs.

[adybbroe]

@djhoese and @mraspaud I restructured a bit in the reader, in order to more easily add the unittest. Don't know if it is to your liking?

[mraspaud]

Thanks for making the code more modular! Just a few details to fix imo

[gerritholl]

It appears to still load seviri.yaml when I try this PR. The sensor seviri is (still) mentioned 121 times in satpy/etc/readers/nwcsaf-geo.yaml, but even if I remove those references it's still loading them, I'm not sure why.

[gerritholl]

The ABI file is available from s3://noaa-goes16/ABI-L1b-RadF/2017/073/20/OR_ABI-L1b-RadF-M3C15_G16_s20170732006100_e20170732016473_c20170732016531.nc

The NWCSAF file:

S_NWC_CMIC_GOES16_NEW-ENGLAND-NR_20170314T200610Z.nc.gz

[adybbroe]

@gerritholl I will have a look at it thanks!

[gerritholl]

This should probably be turned into a unit test or so, it should pass and currently fails:

import satpy
from satpy.utils import debug_on
debug_on()
sc = satpy.Scene(
    {"abi_l1b": ['import/Sat_data/OR_ABI-L1b-RadF-M3C02_G16_s20170732006100_e20170732016467_c20170732016504.nc'],
     "nwcsaf-geo": ['export/CMIC/S_NWC_CMIC_GOES16_NEW-ENGLAND-NR_20170314T200610Z.nc']})
assert "seviri" not in sc.attrs["sensor"]

[adybbroe]

@gerritholl I tested the code snippet above. Works for me!?

[ghost]

Congratulations 🍻. DeepCode analyzed your code in 0.226 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.

---

☺️ If you want to provide feedback on our bot, here is how to contact us.

[adybbroe]

Ok, so now your ABI code above should work @gerritholl
I tested this locally:

import satpy
from satpy.utils import debug_on
debug_on()
sc = satpy.Scene(
    {"abi_l1b": ['/home/a000680/data/goes/abi/OR_ABI-L1b-RadF-M3C15_G16_s20170732006100_e20170732016473_c20170732016531.nc'],
     "nwcsaf-geo": ['/home/a000680/data/goes/nwcsaf/S_NWC_CMIC_GOES16_NEW-ENGLAND-NR_20170314T200610Z.nc']})
print(sc.attrs['sensor'])
sc.load(['cloud_top_phase', 'C15'])
areaid = 'new-england-2000'
lc = sc.resample(areaid, radius_of_influence=20000)
lc.show('cloud_top_phase')
lc.show('C15')

And it works. Using your area-def I got on slack.

I suppose we should move the NWCSAF product recipes into visir.py in another PR.
Any opinion on this @djhoese, @mraspaud, @pnuu and @sfinkens ?

[gerritholl]

Thanks for the PR.

[mraspaud]

LGTM, but I still see a blank line ?