Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make an alias for the snow composite in viirs #1116

Merged
merged 2 commits into from Mar 25, 2020

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Mar 19, 2020

This is a workaround for #151, but also making sure the right channels are used for viirs.

Otherwise, DNB is used as the visible channel, and the nir reflectance computation mixes up resolutions.

  • Tests passed

@mraspaud mraspaud added bug component:dep_tree Dependency tree and dataset loading labels Mar 19, 2020
@mraspaud mraspaud self-assigned this Mar 19, 2020
@ghost
Copy link

ghost commented Mar 19, 2020

Congratulations 🍻. DeepCode analyzed your code in 0.399 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.


☺️ If you want to provide feedback on our bot, here is how to contact us.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.003%) to 89.324% when pulling bb4831a on mraspaud:fix-snow into ec24bcc on pytroll:master.

@coveralls
Copy link

coveralls commented Mar 19, 2020

Coverage Status

Coverage decreased (-0.01%) to 89.313% when pulling 3527ad9 on mraspaud:fix-snow into ec24bcc on pytroll:master.

@mraspaud
Copy link
Member Author

@djhoese @adybbroe (and others interested) do you agree that snow should be an alias for snow_lowres or should we take the high resolution by default ?

@djhoese
Copy link
Member

djhoese commented Mar 19, 2020

I think we've been leaning towards the simplest name means the "best" version of that composite.

@mraspaud
Copy link
Member Author

Works for me, fixing

@codecov
Copy link

codecov bot commented Mar 19, 2020

Codecov Report

Merging #1116 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1116   +/-   ##
=======================================
  Coverage   89.32%   89.32%           
=======================================
  Files         197      197           
  Lines       28999    28999           
=======================================
  Hits        25904    25904           
  Misses       3095     3095

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec24bcc...3527ad9. Read the comment docs.

@mraspaud mraspaud merged commit 216cc6f into pytroll:master Mar 25, 2020
@mraspaud mraspaud deleted the fix-snow branch March 25, 2020 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug component:dep_tree Dependency tree and dataset loading
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants