Fix Scene.crop using PROJ definition to create target area definition #1125
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue is described in #1124. While cropping for
ll_bbox
is not implemented for anything other than thegeos
projection, it should be fine to passxy_bbox
. @meresmata was still getting aNotImplementedError
even after passingxy_bbox
. After some testing by @mraspaud, we discovered that the destination area was usingsrc_area.proj_dict
to create the new AreaDefinition. For the case in #1124 which uses an AreaDefinition based on an EPSG code, this results in pyproj expanding the EPSG code definition to a PROJ.4 dictionary. This new dictionary is not the exact same (string-wise) as the original EPSG based definition (EPSG:32630
).This PR fixes this by using the pyproj
CRS
object if it exists.flake8 satpy