Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the viirs_sdr reader return float32s #1129

Merged
merged 1 commit into from Apr 2, 2020

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Apr 2, 2020

Various operations in the viirs_sdr reader were coercing data to float64 where it wasn't necessary.
This PR fixes this.

  • Tests added
  • Tests passed
  • Passes flake8 satpy
  • Fully documented

@mraspaud mraspaud requested a review from djhoese as a code owner April 2, 2020 12:30
@mraspaud mraspaud self-assigned this Apr 2, 2020
@mraspaud mraspaud changed the title Make viirs sdr return float32s Make the viirs_sdr reader return float32s Apr 2, 2020
Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I think this is a bigger problem that should be handled at the xarray level, this PR looks good to me.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.535% when pulling 8213c91 on mraspaud:fix-viirs-sdr-dtypes into d12bb7a on pytroll:master.

@codecov
Copy link

codecov bot commented Apr 2, 2020

Codecov Report

Merging #1129 into master will not change coverage.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1129   +/-   ##
=======================================
  Coverage   89.53%   89.53%           
=======================================
  Files         200      200           
  Lines       29356    29356           
=======================================
  Hits        26284    26284           
  Misses       3072     3072
Impacted Files Coverage Δ
satpy/readers/viirs_sdr.py 85.95% <66.66%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d12bb7a...8213c91. Read the comment docs.

@mraspaud mraspaud added this to the v0.21.0 milestone Apr 2, 2020
@mraspaud mraspaud merged commit 11bd31d into pytroll:master Apr 2, 2020
@ghost
Copy link

ghost commented Apr 3, 2020

DeepCode failed to analyze this pull request

Something went wrong despite trying multiple times, sorry about that.
Please comment this pull request with "Retry DeepCode" to manually retry, or contact us so that a human can look into the issue.

@mraspaud mraspaud deleted the fix-viirs-sdr-dtypes branch August 17, 2021 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants